Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Postgresql from the Docker build #3208

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Remove Postgresql from the Docker build #3208

merged 1 commit into from
Oct 18, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 18, 2024

It is not a required dependency of Spotlight.

@taylor-steve
Copy link
Contributor

@jcoyne this looks right to me, but could you speak to how you're testing this locally? I think a few of us are struggling with how to review some of the Dockerfile changes because Docker in general isn't working. Are you incorporating some of your other, yet unmerged, Dockerfile PRs? I think if we better understood the direction, we'd have an easier time getting these in. Thanks.

@jcoyne
Copy link
Member Author

jcoyne commented Oct 18, 2024

@taylor-steve I'm not sure how you test a removal of something. Do we need this? Does it break anything that isn't already broken? Does this make it less complicated?

@taylor-steve
Copy link
Contributor

@jcoyne I don't disagree. I'm only looking to remove our confusion by understanding your intent. Thanks for clarifying.

It is not a required dependency of Spotlight.
@taylor-steve taylor-steve merged commit 327ad3c into main Oct 18, 2024
6 checks passed
@taylor-steve taylor-steve deleted the remove-pg branch October 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants